in_prometheus: extract the error log throttling into LogThrottle - #264
Merged
Conversation
kenhys
marked this pull request as draft
August 26, 2026 07:09
Contributor
Author
|
This PR should be rebased with #263 |
kenhys
force-pushed
the
fix-log-throttle
branch
from
August 27, 2026 02:11
c9d98d4 to
69d4360
Compare
kenhys
marked this pull request as ready for review
August 27, 2026 02:11
Watson1978
reviewed
Aug 27, 2026
kenhys
force-pushed
the
fix-log-throttle
branch
from
August 27, 2026 04:56
69d4360 to
24c2c9d
Compare
Contributor
Author
|
Now extracted isolated log_throttle. |
Watson1978
reviewed
Aug 27, 2026
Before: in_prometheus suppressed its repeated error log with a Hash and a Mutex of its own, which filter/out_prometheus could not reach. After: the same mechanism lives in LogThrottle, which in_prometheus uses. No behaviour changes. in_prometheus_spec keeps only what the unit spec cannot cover. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-Authored-By: Claude <noreply@anthropic.com>
kenhys
force-pushed
the
fix-log-throttle
branch
from
August 27, 2026 07:13
24c2c9d to
cb99972
Compare
Watson1978
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: in_prometheus suppressed its repeated error log with a Hash and a
Mutex of its own, which filter/out_prometheus could not reach.
After: the same mechanism lives in LogThrottle, which in_prometheus uses.
No behaviour changes. in_prometheus_spec keeps only what the unit spec
cannot cover.